Sign inJoin
3
5 Comments

A code review tool? 👍👎

by Daniel Veihelmann

Hi Indiehackers!

Here's a project idea that I've worked on recently, and I'm curious to hear your thoughts!

I do a lot of code reviews at work, and I feel staring at pull request diffs isn't the ideal workflow for doing this (we use Gitlab, but it's probably the same for other platforms)

I'm imagining an online tool that would connect to Gitlab and offer a way to review entire files of a pull request without distractions.
In addition, I'd like to make large reviews more manageable by filtering (prod, test, generated) code and things like that.

Sounds good? Lame idea? Let me know! ;)

Daniel Veihelmann's avatarDaniel Veihelmann
on May 25, 2020
Say something nice to danielv…
Post Comment
  1. 1

    Hi @danielv, did you find the tool for code reviews that you were looking for?

    We're actually making just that at Reviewpad. Would you be interested in giving it a try?

    adrianomartins's avatar adrianomartins
    ·
    5 years ago
    ·
    Reply
    1. 1

      Hi Adriano, I couldn't find what I was looking for, so I went ahead and created my own.
      And I guess you've found ReadyforReview already 😉

      While I'm quite happy with what it can do right now, it lacks a couple of features to qualify as a product IMHO. I haven't really had the time to work on it recently, but I have a ton of ideas.

      As for Reviewpad, I'll definitely give it a try! Your website looks really nice, I'm curious!

      Have you tried RFR? Would love to hear your thoughts, since you've been working on something that seems similar.

      Cheers!

      Daniel Veihelmann's avatar Daniel Veihelmann
      ·
      5 years ago
      ·
      Reply
      1. 1

        Indeed, Daniel, I saw it linked on your profile. Looking good.

        I tried to run it earlier but was getting a SyntaxError: Unexpected end of JSON input upon opening any PR. I'm not sure I've done the setup correctly, though. I might try again later on.

        The UI is looking pretty nice and simple, that was one big challenge we faced as well.

        adrianomartins's avatar adrianomartins
        ·
        5 years ago
        ·
        Reply
        1. 1

          Thanks Adriano, and I'm sorry for the late reply (half of my family was sick the whole week...).

          Regarding the error - sorry about that, which OS / GItlab combination are you using?

          I'm really curious to try ReviewPad, but it doesn't seem to work right now. I run it using docker and connected it to gitlab.com, but it seems there is a problem fetching projects and/or merge requests (I've used a full API access token which should work).

          For reference, I'm running Version"fe v29.2021.01 | be v29.2021.01"

          Daniel Veihelmann's avatar Daniel Veihelmann
          ·
          5 years ago
          ·
          Reply
          1. 1

            Hi Daniel, thanks for the interest in Reviewpad! Can you describe what is the problem and how you are adding the project to Reviewpad? It could be easier to chat in our Slack at https://reviewpad.com/slack. Looking forward to hearing from you!

            marcelosousa's avatar marcelosousa
            ·
            5 years ago
            ·
            Reply